X-Git-Url: http://jaekl.net/gitweb/?p=cfb.git;a=blobdiff_plain;f=prod%2Fnet%2Fjaekl%2Fcfb%2Fstore%2FDbStore.java;h=69ea8bbafaeb405ce06ce3387e2f9caa3f490678;hp=fed1f9d9f8b7ab7f8f4700791a8b7b223e09c83e;hb=8e5bdf0294e85b4419ee1e582d5677cccd3f736e;hpb=71a1166c90a757e1faec9756563d35dbc367665b diff --git a/prod/net/jaekl/cfb/store/DbStore.java b/prod/net/jaekl/cfb/store/DbStore.java index fed1f9d..69ea8bb 100644 --- a/prod/net/jaekl/cfb/store/DbStore.java +++ b/prod/net/jaekl/cfb/store/DbStore.java @@ -2,7 +2,6 @@ package net.jaekl.cfb.store; import java.sql.Connection; import java.sql.SQLException; -import java.util.ArrayList; import java.util.List; import net.jaekl.cfb.analyze.Analysis; @@ -15,12 +14,9 @@ import net.jaekl.cfb.db.Sort; import net.jaekl.cfb.db.Table; import net.jaekl.cfb.db.TypeMismatchException; import net.jaekl.cfb.db.driver.DbDriver; -import net.jaekl.cfb.xml.BugClass; import net.jaekl.cfb.xml.BugCollection; import net.jaekl.cfb.xml.BugInstance; -import net.jaekl.cfb.xml.BugMethod; import net.jaekl.cfb.xml.LocalVariable; -import net.jaekl.cfb.xml.SourceLine; import net.jaekl.cfb.xml.messages.MessageCollection; public class DbStore { @@ -80,18 +76,19 @@ public class DbStore { Long foundId = Long.valueOf(m_driver.nextVal(m_con, CfbSchema.FOUND_SEQ)); Long bugId = Long.valueOf(m_msgColl.getPattern(bug.getType()).getId()); Long categoryId = Long.valueOf(m_msgColl.getCategory(bug.getCategory()).getId()); - Location[] locs = computeLocations(bug); - Location firstLoc = (locs.length > 0) ? locs[0] : null; - Location secondLoc = (locs.length > 1) ? locs[1] : null; - Location thirdLoc = (locs.length > 2) ? locs[2] : null; + List locs = bug.getLocations(); + Location firstLoc = (locs.size() > 0) ? locs.get(0) : null; + Location secondLoc = (locs.size() > 1) ? locs.get(1) : null; + Location thirdLoc = (locs.size() > 2) ? locs.get(2) : null; values[row][0] = foundId; - values[row][1] = bugId; - values[row][2] = categoryId; - values[row][3] = getLocId(firstLoc); - values[row][4] = getLocId(secondLoc); - values[row][5] = getLocId(thirdLoc); - values[row][6] = getVarId(bug); + values[row][1] = runId; + values[row][2] = bugId; + values[row][3] = categoryId; + values[row][4] = getLocId(firstLoc); + values[row][5] = getLocId(secondLoc); + values[row][6] = getLocId(thirdLoc); + values[row][7] = getVarId(bug); row++; } @@ -99,61 +96,43 @@ public class DbStore { return (bugs.size() == count); } - Location[] computeLocations(BugInstance bug) + String getBugType(Long bugPatternId) throws SQLException, TypeMismatchException { - ArrayList locs = new ArrayList(); - - /* - Somewhat unfortunate special case. - The primary "location" for a bug instance is split between tags. - Most bugs have a pattern like this: - - ... - - - - ... - - - - The primary location for a bug is given by the with no role attribute, - but the inside that method describes the whole range of lines - covered by that Method, not the spot where the bug is located--that is given - by the that is a direct child fo the . - */ - - BugMethod primaryMethod = null; - SourceLine primaryLine = null; - - for (BugMethod method : bug.getMethods()) { - if (null != method.getRole()) { - primaryMethod = method; - break; - } - } - if (bug.getLines().size() > 0) { - primaryLine = bug.getLines().get(0); - } + Column[] columns = { CfbSchema.TYPE }; + Table[] tables = { CfbSchema.BUGS }; + Condition[] conditions = { new Condition(CfbSchema.BUGID, bugPatternId, Operation.EQUAL) }; + Row row = m_driver.selectExactlyOne(m_con, columns, tables, conditions); + String type = row.getString(0); + return type; + } + + String getCategoryName(Long categoryId) throws SQLException, TypeMismatchException + { + Column[] columns = { CfbSchema.CATEGORY }; + Table[] tables = { CfbSchema.CATEGORIES }; + Condition[] conditions = { new Condition(CfbSchema.CATEGORYID, categoryId, Operation.EQUAL) }; + Row row = m_driver.selectExactlyOne(m_con, columns, tables, conditions); + String name = row.getString(0); + return name; + } + + + Location getLoc(Long locId) throws SQLException, TypeMismatchException + { + Column[] columns = { CfbSchema.CLASSNAME, CfbSchema.METHODNAME, CfbSchema.METHODROLE, CfbSchema.STARTLINE, CfbSchema.ENDLINE }; + Table[] tables = { CfbSchema.LOCATIONS }; + Condition[] conditions = { new Condition(CfbSchema.LOCID, locId, Operation.EQUAL) }; - if ((null != primaryMethod) && (null != primaryLine)) { - locs.add(new Location(primaryMethod, primaryLine)); - } + Row row = m_driver.selectExactlyOne(m_con, columns, tables, conditions); - for (BugMethod method : bug.getMethods()) { - if (primaryMethod != method) { - locs.add(new Location(method)); - } - } - for (SourceLine line : bug.getLines()) { - if (primaryLine != line) { - locs.add(new Location(line)); - } - } - for (BugClass clazz : bug.getClasses()) { - locs.add(new Location(clazz)); - } + String className = row.getString(0); + String methodName = row.getString(1); + String methodRole = row.getString(2); + long startLine = row.getLong(3); + long endLine = row.getLong(4); - return locs.toArray(new Location[locs.size()]); + Location loc = new Location(locId, className, methodName, methodRole, startLine, endLine); + return loc; } Long getLocId(Location loc) throws SQLException, TypeMismatchException @@ -225,6 +204,26 @@ public class DbStore { return getVarId(vars.get(0)); } + LocalVariable getVar(Long varId) throws SQLException, TypeMismatchException + { + Column[] columns = { CfbSchema.NAME, CfbSchema.VARROLE }; + Table[] tables = { CfbSchema.VARIABLES }; + Condition[] conditions = { new Condition(CfbSchema.VARID_PK, varId, Operation.EQUAL) }; + + List result = m_driver.select(m_con, columns, tables, conditions); + if (result.size() < 1) { + throw new SQLException("No variable found for ID " + varId); + } + if (result.size() > 1) { + throw new SQLException("Too many matches (" + result.size() + ") found for variable ID " + varId); + } + + String varName = result.get(0).getString(0); + String varRole = result.get(0).getString(1); + + return new LocalVariable(varId, varName, varRole); + } + Long getVarId(LocalVariable var) throws SQLException, TypeMismatchException { if (null == var) { @@ -320,6 +319,45 @@ public class DbStore { BugCollection getBugCollection(Long runId) throws SQLException, TypeMismatchException { - throw new UnsupportedOperationException("Not yet implemented"); + Column[] columns = { + CfbSchema.FOUNDID, + CfbSchema.BUGID, + CfbSchema.CATEGORYID, + CfbSchema.FIRSTLOCID, + CfbSchema.SECONDLOCID, + CfbSchema.THIRDLOCID, + CfbSchema.VARID_FK + }; + Table[] tables = { + CfbSchema.FOUND + }; + Condition[] conditions = { + new Condition(CfbSchema.RUNID, runId, Operation.EQUAL) + }; + + BugCollection coll = new BugCollection(); + + List rows = m_driver.select(m_con, columns, tables, conditions); + + for (Row row : rows) { + // long foundId = row.getLong(0); + long bugId = row.getLong(1); + long categoryId = row.getLong(2); + long firstLocId = row.getLong(3); + long secondLocId = row.getLong(4); + long thirdLocId = row.getLong(5); + long varId = row.getLong(6); + + String bugType = getBugType(bugId); + String category = getCategoryName(categoryId); + Location[] locations = { getLoc(firstLocId), getLoc(secondLocId), getLoc(thirdLocId) }; + LocalVariable[] vars = { getVar(Long.valueOf(varId)) }; + + + BugInstance bug = new BugInstance(bugId, category, bugType, locations, vars); + coll.getBugs().add(bug); + } + + return coll; } }